Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General clean up #12

Merged
merged 7 commits into from
Jul 1, 2020
Merged

General clean up #12

merged 7 commits into from
Jul 1, 2020
+106 −137

Conversation

EnriqueL8
Copy link
Owner

@EnriqueL8 EnriqueL8 commented Jul 1, 2020 •
edited
Loading

  • Remove CommonPushOptions
  • Move Validation
  • Add spinners for user experience
  • Modify test
  • Remove devfile.yaml flag

upLukeWeston
upLukeWeston reviewed Jul 1, 2020
View reviewed changes
pkg/util/util.go Outdated Show resolved Hide resolved
@EnriqueL8 EnriqueL8 changed the title [WIP] Remove CommonPushOptions and do some clean up Remove CommonPushOptions and do some clean up Jul 1, 2020
@EnriqueL8 EnriqueL8 changed the title Remove CommonPushOptions and do some clean up General clean up Jul 1, 2020
groeges
groeges suggested changes Jul 1, 2020
View reviewed changes
pkg/util/util.go Outdated Show resolved Hide resolved
pkg/util/util.go Outdated Show resolved Hide resolved
pkg/util/util.go Outdated Show resolved Hide resolved
pkg/util/util.go Outdated Show resolved Hide resolved
pkg/devfile/adapters/kubernetes/component/adapter.go Outdated Show resolved Hide resolved
pkg/devfile/adapters/kubernetes/component/adapter.go Outdated Show resolved Hide resolved
groeges
groeges approved these changes Jul 1, 2020
View reviewed changes
Copy link

@groeges groeges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EnriqueL8 EnriqueL8 merged commit 1008511 into deploy_command Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groeges groeges groeges approved these changes

@upLukeWeston upLukeWeston upLukeWeston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EnriqueL8 @groeges @upLukeWeston